Build Speed - using static git information for debug build config #5668

ouchadam · 2022-03-30T12:45:35Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Only applies the git meta information to release builds, by dynamically including it in all build types we end up invalidating our local caches causing cascading compilation across the modules

Motivation and context

To speed up the build when no code changes have been made

Screenshots / GIFs

Notice the dev mentions instead of the current git sha for the debug build

ONBOARDING	ABOUT

Tests

Setup

./gradlew assembleGplayDebug  # 3m 30s~
./gradlew assembleGplayDebug  # 1s

git commit -m "empty commit" --allow-empty # or checkout a new branch

The next build after changing git sha...

Before

./gradlew assembleGplayDebug  # 3m~

After

./gradlew assembleGplayDebug  # 18s~

Hopefully in the future we'll be able to automate this benchmark gradle/gradle-profiler#335

**note build times are dependent on system specs

Tested devices

Physical
Emulator
OS version(s): 31 Sv2

- avoids commits causing module invalidation, increasing the build time

github-actions · 2022-03-30T13:44:36Z

Unit Test Results

110 files ±0 110 suites ±0 1m 17s ⏱️ +10s
195 tests ±0 195 ✔️ ±0 0 💤 ±0 0 ❌ ±0
650 runs ±0 650 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit f739ca1. ± Comparison against base commit 9d3d574.

bmarty · 2022-03-30T14:54:55Z

vector/build.gradle

-
-        buildConfigField "String", "GIT_REVISION", "\"${gitRevision()}\""
-        buildConfigField "String", "GIT_REVISION_DATE", "\"${gitRevisionDate()}\""
-        buildConfigField "String", "GIT_BRANCH_NAME", "\"${gitBranchName()}\""


It's quite annoying not to have the branch name. I use it to check that I am on the correct version when installing an APK built from Buildkite.
I guess I can live without that. Or we can include it when built on the CI, but not when built on a local computer?

I also agree, I find the branch name quite useful for quickly confirming build origins

I'll have a bit more of a play around which the separate cacheable module approach to see if there's a way to play nice with the SDK project (without resorting to releasing a another artifact)

ericdecanini

I agree with what @bmarty says. It would be good to get the branch name back

ouchadam · 2022-03-31T07:59:57Z

going to close and revisit the module + scripting approach after my current tasks are complete

ouchadam added 2 commits March 30, 2022 13:19

using static git information for debug build config

dbfebaf

- avoids commits causing module invalidation, increasing the build time

adding changelog entry

56c11b1

ouchadam requested review from a team and ericdecanini and removed request for a team March 30, 2022 13:13

updating changelog copy

f739ca1

bmarty reviewed Mar 30, 2022

View reviewed changes

ericdecanini reviewed Mar 30, 2022

View reviewed changes

ouchadam closed this Mar 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build Speed - using static git information for debug build config #5668

Build Speed - using static git information for debug build config #5668

ouchadam commented Mar 30, 2022 •

edited

Loading

github-actions bot commented Mar 30, 2022

bmarty Mar 30, 2022

ouchadam Mar 30, 2022

ericdecanini left a comment

ouchadam commented Mar 31, 2022

Build Speed - using static git information for debug build config #5668

Build Speed - using static git information for debug build config #5668

Conversation

ouchadam commented Mar 30, 2022 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Setup

Before

After

Tested devices

github-actions bot commented Mar 30, 2022

Unit Test Results

bmarty Mar 30, 2022

Choose a reason for hiding this comment

ouchadam Mar 30, 2022

Choose a reason for hiding this comment

ericdecanini left a comment

Choose a reason for hiding this comment

ouchadam commented Mar 31, 2022

ouchadam commented Mar 30, 2022 •

edited

Loading